-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(grid) sorting indicator and dark theme colors #10560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the column header is selected, this change make sure that it will be visible no mater the background color.
desig9stein
added
❌ status: awaiting-test
PRs awaiting manual verification
grid: column-selection
version: 13.0.x
labels
Nov 18, 2021
desig9stein
changed the title
refactor(grid) sorting indicator colors
refactor(grid) sorting indicator and dark theme colors
Nov 18, 2021
@desig9stein Tests are failing. |
simeonoff
approved these changes
Nov 19, 2021
simeonoff
added
💥 status: in-test
PRs currently being tested
✅ status: verified
Applies to PRs that have passed manual verification
and removed
❌ status: awaiting-test
PRs awaiting manual verification
💥 status: in-test
PRs currently being tested
labels
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grid: column-selection
version: 13.0.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10551
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)