Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(grid) sorting indicator and dark theme colors #10560

Merged
merged 12 commits into from
Nov 22, 2021

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Nov 18, 2021

Closes #10551

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

…when the column header is selected, this change make sure that it will be visible no mater the background color.
@desig9stein desig9stein changed the title refactor(grid) sorting indicator colors refactor(grid) sorting indicator and dark theme colors Nov 18, 2021
@simeonoff
Copy link
Collaborator

@desig9stein Tests are failing.

@simeonoff simeonoff added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 22, 2021
@zdrawku zdrawku merged commit bd5efcf into master Nov 22, 2021
@zdrawku zdrawku deleted the mpopov/sorting-indicator branch November 22, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: column-selection version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting indicator is blending with the selected header color
4 participants